Skip to content

lomiri.lomiri-terminal-app: init at 2.0.2#247112

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
OPNA2608:init/lomiri/lomiri-terminal-app
Jan 17, 2024
Merged

lomiri.lomiri-terminal-app: init at 2.0.2#247112
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
OPNA2608:init/lomiri/lomiri-terminal-app

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Aug 4, 2023 •
edited
Loading

Description of changes

Working towards #99090.

Lomiri Terminal App. Self-explanatory.
image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 4, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 4, 2023
@ofborg ofborg bot requested a review from svenkeidel August 4, 2023 12:56
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 4, 2023
@OPNA2608 OPNA2608 removed the request for review from svenkeidel August 4, 2023 13:00
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Aug 4, 2023

(Un-requested the automatic review request, as the change pertaining to them (libsforQt5.qmltermwidget) has a separate PR)

@OPNA2608 OPNA2608 mentioned this pull request Oct 13, 2023
Open
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from dc9f57d to e7d3260 Compare November 13, 2023 10:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 13, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from e7d3260 to 2e1a35a Compare November 13, 2023 22:05
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch 2 times, most recently from 9c8f0de to 05f34b2 Compare December 19, 2023 15:54
@OPNA2608

This comment was marked as resolved.

Sign in to view
@OPNA2608 OPNA2608 changed the title lomiri.lomiri-terminal-app: init at 2.0.1 lomiri.lomiri-terminal-app: init at 2.0.2 Dec 19, 2023
@OPNA2608 OPNA2608 mentioned this pull request Dec 19, 2023
Merged
13 tasks
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from 05f34b2 to aa6f4ac Compare December 19, 2023 19:13
@OPNA2608

This comment was marked as resolved.

Sign in to view
@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 19, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from aa6f4ac to 26aae5e Compare December 20, 2023 00:39
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 20, 2023
@OPNA2608 OPNA2608 mentioned this pull request Dec 21, 2023
Merged
12 tasks
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from 26aae5e to 6d8373b Compare January 15, 2024 17:49
@OPNA2608 OPNA2608 marked this pull request as ready for review January 15, 2024 17:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 15, 2024
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 17, 2024

Looking really clean, great work 👍🏼

@SuperSandro2000 SuperSandro2000 merged commit 23a88af into NixOS:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OPNA2608 @SuperSandro2000

Comments